Skip to content

Conversation

@CySSoO
Copy link
Contributor

@CySSoO CySSoO commented Sep 5, 2025

Summary

  • add everblock_video_gallery with video URL, title and description fields
  • render video gallery with modal playback
  • style and script support for gallery

Testing

  • php -l models/EverblockPrettyBlocks.php
  • php -l config/allowed_files.php
  • php -l translations/gb.php
  • php -l translations/fr.php
  • php -l translations/it.php
  • php -l translations/nl.php

https://chatgpt.com/codex/tasks/task_e_68bacde420c48322964ea6c15106e286

@CySSoO CySSoO merged commit 85c1093 into master Sep 5, 2025
0 of 6 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

<div class="card {if isset($state.css_class) && $state.css_class}{$state.css_class|escape:'htmlall':'UTF-8'}{/if}">
<img src="{$state.thumbnail.url|replace:'.webp':'.jpg'}" class="img-fluid cursor-pointer" alt="{$state.title}" title="{$state.title}" loading="lazy" data-block="{$block.id_prettyblocks}" data-video-url="{$state.video_url|escape:'htmlall':'UTF-8'}" data-description="{$state.description|escape:'htmlall':'UTF-8'}" data-bs-toggle="modal" data-bs-target="#videoModal-{$block.id_prettyblocks}">
{if $state.title || $state.description}
<div class="card-body">
{if $state.title}<h5 class="card-title">{$state.title}</h5>{/if}
{if $state.description}<p class="card-text">{$state.description}</p>{/if}

[P1] Escape user-provided titles in img attributes

The new template injects {$state.title} directly into the alt and title attributes of each thumbnail without escaping. Because these values come from the block configuration, a title containing quotes such as My video" onerror="alert(1) will break the attribute and execute arbitrary HTML/JS when the gallery is rendered. Other attributes in the same tag are already escaped, so these should also be wrapped in |escape:'htmlall':'UTF-8' before outputting.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants