Add responsive column option to lookbook block #330
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| 'columns' => [ | ||
| 'type' => 'select', | ||
| 'label' => $module->l('Columns on desktop'), | ||
| 'default' => '1', | ||
| 'options' => [ | ||
| [ | ||
| 'label' => '1', | ||
| 'value' => '1', | ||
| ], | ||
| [ | ||
| 'label' => '2', | ||
| 'value' => '2', | ||
| ], | ||
| [ | ||
| 'label' => '3', | ||
| 'value' => '3', | ||
| ], | ||
| ], |
There was a problem hiding this comment.
[P1] Populate select with choices, not options array
The new lookbook configuration field declares a select input but fills it using an options array of label/value pairs. Every other select in this class uses the choices associative array (e.g. the heading level select earlier in the file), which is what the PrettyBlocks builder expects when rendering forms. With options the control will render empty and the column count can never be changed, so the responsive layout feature introduced here can’t actually be configured.
Useful? React with 👍 / 👎.
Summary
Testing
php -l models/EverblockPrettyBlocks.phphttps://chatgpt.com/codex/tasks/task_e_68c05b4d9e64832296f104076554fba8