Load video products via AJAX #349
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| }, | ||
| success: function (html) { | ||
| let modalId = 'productVideoModal-' + blockId; | ||
| let modal = $('<div>', { | ||
| 'class': 'modal fade everblock-video-product-modal', |
There was a problem hiding this comment.
[P1] Fail gracefully when no products can be loaded
The click handler now creates the modal only inside the AJAX success callback. When the request fails (invalid token, network error) or when a block is configured without product_ids—which was previously allowed—the controller returns 4xx and the success handler never runs, so no modal is instantiated and the video cannot be played at all. Before this change, videos opened regardless and the products list was simply empty. Consider creating the modal before the request and populating it conditionally so that videos still open even when product data is unavailable.
Useful? React with 👍 / 👎.
Summary
videoproductsfront controllerTesting
php -l controllers/front/videoproducts.phpphp -l config/allowed_files.phpnode --check views/js/everblock.jshttps://chatgpt.com/codex/tasks/task_e_68c3c53501b88322abfae16bdc58bf62