Refactor guided selector block #363
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| public function hookBeforeRenderingEverblockGuidedSelector($params) | ||
| { | ||
| $states = $params['block']['states'] ?? []; | ||
|
|
||
| foreach ($states as &$state) { | ||
| $question = isset($state['question']) ? trim($state['question']) : ''; | ||
| $state['question'] = $question; | ||
| $state['key'] = Tools::link_rewrite($question); | ||
|
|
||
| $answers = []; | ||
| $lines = preg_split("/(\r\n|\r|\n)/", $state['answers'] ?? ''); | ||
| foreach ($lines as $line) { | ||
| $parts = explode('|', $line); | ||
| $text = trim($parts[0] ?? ''); | ||
| if ($text === '') { | ||
| continue; | ||
| } | ||
| $link = trim($parts[1] ?? ''); | ||
| $answers[] = [ | ||
| 'text' => $text, | ||
| 'link' => $link, | ||
| 'value' => Tools::link_rewrite($text), | ||
| ]; | ||
| } | ||
| $state['answers'] = $answers; | ||
| } |
There was a problem hiding this comment.
[P0] Handle legacy guided selector answer arrays
The new pre-render hook parses answers as a newline-delimited string, but existing guided selector blocks saved before this refactor still store answers as repeater arrays. When such a block is rendered, $state['answers'] is an array and the call to preg_split() raises a fatal TypeError (“Argument #2 must be of type string, array given”), bringing down the page. Consider supporting both array and string formats or migrating stored data during upgrade so upgraded shops do not crash.
Useful? React with 👍 / 👎.
Summary
link_rewritemodifierTesting
composer validate --quietphp -l everblock.phpphp -l models/EverblockPrettyBlocks.phpvendor/bin/phpstan analyse --no-progress --level 0(fails: No such file or directory)https://chatgpt.com/codex/tasks/task_e_68c4454c24c48322bb039dd95860b5bc