Add wheel of fortune prettyblock #364
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
controllers/front/wheel.php
Outdated
| $segments = Tools::getValue('segments'); | ||
| if (is_string($segments)) { | ||
| $segments = json_decode($segments, true); | ||
| } | ||
| if (!is_array($segments) || empty($segments)) { | ||
| die(json_encode([ | ||
| 'status' => false, | ||
| 'message' => $this->module->l('No segments available', 'wheel'), | ||
| ])); | ||
| } | ||
| $prefix = Tools::getValue('coupon_prefix', 'WHEEL'); | ||
| $validity = (int) Tools::getValue('coupon_validity', 30); | ||
| $discountType = Tools::getValue('coupon_type', 'percent'); | ||
| $couponName = Tools::getValue('coupon_name', 'Wheel reward'); |
There was a problem hiding this comment.
[P0] Validate wheel spin parameters server-side
The spin controller reads segments, coupon_prefix, coupon_validity, coupon_type, and coupon_name directly from the POST payload (around lines 45‑58) and uses them to determine which prize wins and what coupon is created, without cross-checking the saved PrettyBlock configuration. Any authenticated user can POST an arbitrary JSON array and discount values to /module/everblock/wheel and obtain a voucher with any amount, percent, validity or code prefix they choose, effectively bypassing the intended probabilities and limits. This allows trivial creation of high-value coupons and undermines the marketing rules for the wheel.
Useful? React with 👍 / 👎.
Summary
everblock.jsusing jQueryTesting
php -l controllers/front/wheel.phpphp -l models/EverblockPrettyBlocks.phphttps://chatgpt.com/codex/tasks/task_e_68c5adfc94dc8322a20c50d081b83554