Simplify holiday hours configuration #369
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| $result = []; | ||
| $holidays = self::getFrenchHolidays((int) date('Y')); | ||
| foreach ($holidays as $date) { | ||
| $openKey = 'EVERBLOCK_OPEN_' . (int) $storeId . '_' . $date; | ||
| $closeKey = 'EVERBLOCK_CLOSE_' . (int) $storeId . '_' . $date; | ||
| $open = Configuration::get($openKey); | ||
| $close = Configuration::get($closeKey); | ||
| if ($open && $close) { | ||
| $result[$date] = trim($open) . ' - ' . trim($close); | ||
| $hoursKey = 'EVERBLOCK_HOLIDAY_HOURS_' . (int) $storeId . '_' . $date; | ||
| $hours = Configuration::get($hoursKey); | ||
| if ($hours) { | ||
| $result[$date] = trim($hours); |
There was a problem hiding this comment.
[P1] Migrate existing holiday hour configuration
The new implementation only reads and saves EVERBLOCK_HOLIDAY_HOURS_* entries and no longer looks at the previous EVERBLOCK_OPEN_* and EVERBLOCK_CLOSE_* configuration keys. Shops that already configured holiday opening and closing times will now have empty fields in the back office and the store locator will treat every holiday as closed until an administrator re-enters the data. Consider migrating the old OPEN_/CLOSE_ values into the new combined field or providing a fallback so existing stores keep their configured holiday hours.
Useful? React with 👍 / 👎.
Summary
EVERBLOCK_HOLIDAY_HOURS_*getStoreHolidayHoursConfigTesting
php -l everblock.phpphp -l models/EverblockTools.phpvendor/bin/phpstan analyse everblock.php models/EverblockTools.php(fails: vendor/bin/phpstan: No such file or directory)composer global require phpstan/phpstan(fails: curl error 56 while downloading https://repo.packagist.org/packages.json: CONNECT tunnel failed, response 403)https://chatgpt.com/codex/tasks/task_e_68c7b2912324832280121ac6bf413b0a