Skip to content

Conversation

@CySSoO
Copy link
Contributor

@CySSoO CySSoO commented Sep 19, 2025

Summary

  • remove PrettyBlocks and Shortcode PSR-4 namespaces from Composer autoload configuration to retire those directories

Testing

  • no tests were run (not applicable)

https://chatgpt.com/codex/tasks/task_e_68cd12e25868832288ba3d3de10cda83

@CySSoO CySSoO merged commit fd098e5 into master Sep 19, 2025
0 of 4 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

everblock/composer.json

Lines 11 to 15 in 421a6f5

"autoload": {
"psr-4": {
"Everblock\\Tools\\": "src/"
},
"exclude-from-classmap": []

[P1] Removing PSR-4 mappings breaks PrettyBlocks and Shortcode classes

Deleting the Everblock\\PrettyBlocks\\ and Everblock\\Shortcode\\ namespaces from Composer autoload leaves dozens of classes without an autoloader. They are still instantiated in the module—for example models/EverblockTools.php imports Everblock\\Shortcode\\ShortcodeHandlerRegistry and models/EverblockPrettyBlocks.php uses Everblock\\PrettyBlocks\\BlockRegistry. After a composer dump-autoload (or any fresh install) these classes can no longer be resolved and features such as shortcode rendering or PrettyBlocks will throw Class not found errors. If these namespaces are truly unused, their PHP files should be removed; otherwise the autoload mappings need to stay.


Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants