Refactor config form into tabbed helper form #442
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| $settingsInputs = [ | ||
| [ | ||
| 'type' => 'html', | ||
| 'name' => 'anchor_everblock_settings', | ||
| 'html_content' => '<span id="everblock_settings"></span>', | ||
| ], | ||
| [ | ||
| 'type' => 'text', | ||
| 'lang' => true, | ||
| 'label' => $this->l('New order step title'), | ||
| 'desc' => $this->l('Please specify new order step title'), | ||
| 'hint' => $this->l('If not set, new order step won\'t be shown'), | ||
| 'name' => 'EVEROPTIONS_TITLE', | ||
| 'required' => true, | ||
| ], |
There was a problem hiding this comment.
[P1] Merging forms makes tool buttons unusable when required fields are empty
The refactor now builds a single tabbed HelperForm that contains both the configuration inputs and the action buttons (cache purge, file uploads, etc.). Inputs like EVEROPTIONS_TITLE remain marked required. When a merchant clicks a button such as submitEmptyCache or submitUploadTabsFile, the browser validates the whole form and refuses to submit while these required fields are blank (a common state on fresh installs or when the title is intentionally unset), preventing the tool/import actions from ever firing. Previously each section had its own form without required fields, so these actions worked even with empty settings. Consider moving the utility buttons back into their own form or removing the required attribute for optional fields so that auxiliary actions can be executed.
Useful? React with 👍 / 👎.
Summary
getConfigForm()so it returns a single tabbed HelperForm covering tools, settings, imports, design, and advanced sectionsTesting
https://chatgpt.com/codex/tasks/task_e_68cd8b49d67c8322bd716402c1e565b3