Change number field types to text #513
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| 'max_winners' => [ | ||
| 'type' => 'number', | ||
| 'type' => 'text', | ||
| 'label' => $module->l('Maximum winners for this segment (0 for unlimited)'), | ||
| 'default' => '0', |
There was a problem hiding this comment.
The PrettyBlocks definition for max_winners now uses type => 'text', which means the admin UI no longer constrains the field to numbers. However the game controllers still cast this setting with (int) and treat 0 as “unlimited winners” (see controllers/front/wheel.php and controllers/front/scratch.php where max_winners is cast without validation). A non‑numeric input such as 'foo' will therefore become 0 and silently remove the intended cap on rewards. Either keep this field numeric or add server‑side validation to reject non‑numeric values before casting to avoid disabling winner limits by mistake.
Useful? React with 👍 / 👎.
Summary
numbertype withtextto allow non-numeric inputTesting
https://chatgpt.com/codex/tasks/task_e_68e4df48d6b483229d33725251978584