Refactor Everblock tools to injectable services #555
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if ($this->everBlockShortcodeProvider instanceof EverBlockShortcodeProvider) { | ||
| EverblockPrettyBlocks::setShortcodeProvider($this->everBlockShortcodeProvider); | ||
| EverblockTools::setShortcodeProvider($this->everBlockShortcodeProvider); | ||
| $this->getLegacyToolsService()->setShortcodeProvider($this->everBlockShortcodeProvider); |
There was a problem hiding this comment.
Inside Everblock::bootstrapDependencies, the code invokes $this->getLegacyToolsService()->setShortcodeProvider(...) before setting $this->dependenciesBootstrapped to true. getLegacyToolsService() immediately calls bootstrapDependencies() again (lines 279‑281), so the initial bootstrap calls back into itself indefinitely and will exhaust the stack whenever the module is instantiated. Use the already resolved $this->legacyToolsService or mark the bootstrap as complete before calling back into getLegacyToolsService().
Useful? React with 👍 / 👎.
| - { name: 'everblock.shortcode_handler' } | ||
|
|
||
| everblock.shortcode_handler.instagram: | ||
| class: Everblock\Tools\Shortcode\Handler\CallbackShortcodeHandler |
There was a problem hiding this comment.
Several service definitions inject @Everblock\Tools\Service\Legacy\EverblockToolsService, but this service id is never registered anywhere in services.yml. Because the container only knows about services declared in this file, building the module will fail with “You have requested a non-existent service” when compiling any handler that references the legacy tools service. Add an explicit definition such as Everblock\Tools\Service\Legacy\EverblockToolsService: ~ (or adjust references) so the container can instantiate and inject it.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f3d2c2932c8322a80edfd9480e90c1