Improve admin product modal media handling #615
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| $targetDir = $this->ensureModalDirectory($productId); | ||
|
|
||
| if (!empty($modal->file)) { | ||
| $oldFile = _PS_IMG_DIR_ . 'cms/' . $modal->file; | ||
| if (file_exists($oldFile)) { | ||
| @unlink($oldFile); | ||
| $this->cleanupModalDirectory(dirname($oldFile)); | ||
| } | ||
| } | ||
|
|
||
| $extension = pathinfo($uploadedFile['name'], PATHINFO_EXTENSION); | ||
| if ($extension) { | ||
| $extension = Tools::strtolower($extension); | ||
| } | ||
|
|
||
| $fileName = uniqid('everblock_modal_'); | ||
| if (!empty($extension)) { | ||
| $fileName .= '.' . $extension; | ||
| } | ||
| $fileName = $this->sanitizeModalFileName($uploadedFile['name']); | ||
| $destinationPath = $targetDir . $fileName; | ||
|
|
||
| if (!move_uploaded_file($uploadedFile['tmp_name'], $dir . $fileName)) { | ||
| if (!move_uploaded_file($uploadedFile['tmp_name'], $destinationPath)) { | ||
| $response['message'] = $this->l('Unable to move the uploaded file.'); |
There was a problem hiding this comment.
When replacing an existing modal file the code deletes the product’s directory by calling cleanupModalDirectory(dirname($oldFile)) immediately after @unlink. Because this happens before move_uploaded_file runs, the directory no longer exists and the move fails, yielding the "Unable to move the uploaded file" response whenever a product already had a modal file. The same ordering appears later in the product update hook. Cleanup should only occur when no new file is saved or after the new file has been successfully written so the destination folder still exists for the upload.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68ff623cdd648322b2c3feb462bd1b8a