Refactor flash deals hook to rely on price drop data #631
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private function getPricesDropProducts(int $requestedProductCount, string $sortBy, string $sortDirection): array | ||
| { | ||
| $products = Product::getPricesDrop( |
There was a problem hiding this comment.
The new implementation unconditionally invokes Product::getPricesDrop with nine parameters including the Context instance. Earlier code used reflection to adapt to the different method signatures that PrestaShop exposes across releases (some versions have no context parameter or expect it in a later position). Without that check, shops running those versions will hit a fatal ArgumentCountError as soon as the flash deals hook executes. Consider restoring the signature detection or providing a safe fallback so the module remains compatible with older cores.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_69022faaf0e08322bc9a5a572800c657