Fix host comparison and use Tools::file_get_contents for image downloads #740
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
file_get_contentsproduced PHP warnings when remote fetches failed during image downloads.Description
parse_url(Tools::getHttpHost(true), PHP_URL_HOST)and fall back toTools::getHttpHost(false)when necessary.urlToFilePathto compareparsedUrl['host']against the extractedcurrentHostso same-host URLs are treated as local.file_get_contents($url)withTools::file_get_contents($url)indownloadImageto use the framework’s safer fetch helper.urlToFilePathreturns a local filesystem path for same-host images anddownloadImagereturns false on download failure.Testing
Codex Task