Remove checkLatestEverModuleVersion usage and add PrettyBlocks admin controller
#744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation - Provide a back-office management UI for PrettyBlocks entries when the external `prettyblocks` module is present. - Allow admins to list PrettyBlocks entries and perform actions such as delete and duplicate from the Everblock configuration area. - Offer helpers to convert PrettyBlocks between shops and between languages to simplify migration tasks. - Keep behaviour safe if the `prettyblocks` module or its DB schema is not present by detecting availability and schema at runtime. ### Description - Added `controllers/admin/AdminEverBlockPrettyblockController.php` which detects the `prettyblocks` table schema at runtime and exposes a list with actions for `delete`, `duplicate`, bulk delete and conversion forms; it implements `renderConversionForms`, `processConvertShop`, `processConvertLang`, and `duplicatePrettyblock` logic. - Register the new admin tab `AdminEverBlockPrettyblock` conditionally during install/uninstall via a new helper `hasPrettyblocksModule()` added to `everblock.php`, and remove the tab during uninstall if present. - Centralised PrettyBlocks availability checks by replacing repeated inline checks with the new `hasPrettyblocksModule()` method and used it for hook registration paths (`actionRegisterBlock`, `beforeRenderingEverblock*`). - Integrated the new controller into admin media loading by adding `AdminEverBlockPrettyblockController` to the module controllers list in `hookActionAdminControllerSetMedia` so admin assets are loaded for the controller. ### Testing - No automated tests were executed for these changes (no CI/unit tests run as part of this rollout).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
display_upgradeflag to avoid calling the removed check.prettyblocksdata from the back office.prettyblocksmodule is present.Description
checkLatestEverModuleVersionmethod and alldisplay_upgradeassignments and usages ineverblock.phpand admin controllers so the upgrade check is no longer executed.views/templates/admin/configure.tplso the upgrade UI block is no longer rendered.controllers/admin/AdminEverBlockPrettyblockController.phpthat implements listing, delete, duplication, bulk delete, and duplication between shops and languages for PrettyBlocks entries.hasPrettyblocksModule()ineverblock.phpand wired conditional tab install/uninstall, conditional hook registration, and addedAdminEverBlockPrettyblockControllerto the admin media registration list inhookActionAdminControllerSetMediaso PrettyBlocks features are only active when available.Testing
Codex Task