Fix Smarty override handling in Google reviews block #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

CySSoO merged 1 commit into master from cyssoo/fix-smarty-template-syntax-error-nytyv4

Jan 15, 2026

Contributor

CySSoO commented Jan 15, 2026

Motivation

Prevent a SmartyCompilerException caused by inline ternary/isset(...) ? ... : ... usage inside the overrides array in the Google reviews prettyblock template.
Normalize optional boolean/flag overrides before building the overrides array so Smarty's parser does not choke on ternary expressions.

Description

Replace inline ternary isset($state.foo) ? $state.foo : null expressions with pre-assigned variables show_rating_override, show_avatar_override, and show_cta_override that are set to null and conditionally assigned when present.
Use the normalized variables in the overrides array construction instead of the ternary expressions.
Modified file: views/templates/hook/prettyblocks/prettyblock_google_reviews.tpl.

Testing

No automated tests were executed for this change.
Template parsing error was addressed by source change and committed, but no CI/test run was performed.


          Fix smarty override handling in Google reviews block

310cc1e

CySSoO added the codex label

— with

ChatGPT Codex Connector

CySSoO merged commit e242022 into master

2 of 6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels