Align simple image slider arrows to active image#873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
div.ever-slider-navaround the prev/next buttons inviews/templates/hook/prettyblocks/prettyblock_img.tplso arrows are positioned relative to the active image.views/css/everblock.cssto place the nav container using CSS variables--ever-slider-active-center-x,--ever-slider-active-center-y,--ever-slider-active-width, and--ever-slider-active-height, and make the individual buttons clickable while keeping the nav anchored to the active image.views/js/everblock-slider.jsby replacingupdateActiveWidthwithupdateActiveMetrics, computing the active image's width, height and center coordinates on image load/resize/slide change, and exposing those values as CSS variables to drive nav placement; the slider state now stores thenavelement and unhides it once metrics are computed.aria-label).Testing
Codex Task