Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
prev/nextbuttons, touch swipes and trackpad gestures without relying on page vertical scroll.Description
views/css/everblock.cssto use a real horizontal track by making.heroe-carousel-trackdisplay: flexand addingtransition: transform 0.8s ...andwill-change: transform, changed.heroe-slidefromposition: absolutetoposition: relativewithflex: 0 0 100%, and set container overflow tovisibleto allow adjacent slides to be visible.views/js/everblock.jsto wire a real index/track movement by selecting the track and applyingtrack.style.transform = 'translateX(-' + (index * 100) + '%)', preserved theis-active/is-next/is-prevstate logic, and added guards for missing track.wheelhandlers to support tactile swipes and trackpad horizontal gestures, plus preservedprev/nextbutton behavior and loop handling; the carousel now advances using the index and transform rather than any vertical scroll or absolute-position illusion.Testing
Codex Task