Fix Heroe carousel translate offset #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

CySSoO merged 1 commit into master from cyssoo/fix-hero-carousel-slider-functionality

Jan 29, 2026

Contributor

CySSoO commented Jan 29, 2026

Motivation

Prevent the Heroe carousel from computing invalid translateX offsets when slide or carousel sizes are zero/NaN which can break click/touch navigation.

Description

Add guards in initHeroeCarousels updateSlides() in views/js/everblock.js to early-return when slideWidth or carouselWidth are falsy and to validate translateX with isFinite, falling back to translateX(0px).

Testing

No automated tests were run for this change.


          Fix heroe carousel translate offset

18f0654

CySSoO added the codex label

— with

ChatGPT Codex Connector

CySSoO merged commit f80c80b into master

0 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels