Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
context['template']pour les blocs « latest pages » et garderpages.tplcomme source par défaut sauf règle métier explicite.pages-alt.tpluniquement quand une condition claire est fournie (par ex.template_variant=alt).pages.tpletpages-alt.tplen factorisant le rendu des cards de pages.Description
shouldUseAlternatePagesTemplate()danssrc/Service/QcdThirdPartyBlockRenderer.phpqui vérifietemplate_variantdans le contexte.renderLatestPagesContext()ne force pluscontext['template']systématiquement et ne définitpages-alt.tplque sishouldUseAlternatePagesTemplate()renvoietrue.views/templates/front/_partials/pages-list-items.tplet inclusion de ce partial depuisviews/templates/front/pages.tpletviews/templates/front/pages-alt.tpl.views/templates/front/_partials/index.phpet mise à jour de la whitelistconfig/allowed_files.phppour inclure les nouveaux fichiers templates/partials.Testing
php -l src/Service/QcdThirdPartyBlockRenderer.phpa été exécuté et a réussi sans erreurs de syntaxe.php -l config/allowed_files.phpa été exécuté et a réussi sans erreurs de syntaxe.http://localhosta échoué (échec attendu dans cet environnement car le service local n’est pas accessible), donc aucun rendu visuel n’a été validé ici.Codex Task