Merged
Conversation
kussu0998
approved these changes
Feb 21, 2026
Contributor
|
@copilot Could you look into this? |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Vietnamese (vi-VN) translation for the Phira rhythm game, aligning it with recent changes in the en-US source strings. The translator has improved accuracy, translated previously untranslated terms (like cache-related strings), and adjusted text to avoid truncation/clipping in the UI.
Changes:
- Updated and corrected translation strings across multiple
.ftlfiles to align with the en-US source (e.g., adding newitem-clear-cachekeys insettings.ftl, expanding upload rules insong.ftlto 6 items, updatingresource.ftlintro text). - Added consistent punctuation (periods, ellipses) to status and error messages.
- Revised several translated terms for accuracy (e.g.,
dim→ "Độ sáng nền" to match en-US "Background Brightness",rks-delta→ "THAY ĐỔI RKS").
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
prpr/locales/vi-VN/scene.ftl |
Added translation for new audio-backend-init-failed key |
prpr/locales/vi-VN/parser.ftl |
Improved several error message translations |
prpr/locales/vi-VN/game.ftl |
Added periods and corrected offset-reset translation |
prpr/locales/vi-VN/ending.ftl |
Updated rks-delta label and added ellipses to in-progress messages |
prpr/locales/vi-VN/chart_info.ftl |
Corrected dim, added enable-unlock/unlock-file translations |
phira/locales/vi-VN/song.ftl |
Major update: upload rules expansion, punctuation additions, term corrections |
phira/locales/vi-VN/settings.ftl |
Added cache-related strings, updated about section with Discord info |
phira/locales/vi-VN/resource.ftl |
Condensed chapter intro into a single paragraph |
phira/locales/vi-VN/multiplayer.ftl |
Simplified create-invalid-id message |
phira/locales/vi-VN/login.ftl |
Shortened login subtitle and field length descriptions |
phira/locales/vi-VN/event.ftl |
Simplified scroll-down-for-more text |
phira/locales/vi-VN/common.ftl |
Updated del-confirm/del-confirm-content and warn-deny-tos-policy |
phira/locales/vi-VN/collection.ftl |
Updated label casing to uppercase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@natelyt12 Hey sorry to bother but it would be great if you look into these comments |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Mivik
approved these changes
Mar 3, 2026
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed some changes in the original (en-US) translation, so I reviewed and updated my translation slightly.
Changes: