Refactor of flow tools - OpenGraph.isclose
#374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 86.25% 86.31% +0.05%
==========================================
Files 44 44
Lines 6161 6166 +5
==========================================
+ Hits 5314 5322 +8
+ Misses 847 844 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matulni
changed the title
OpenGraph comparison.OpenGraph.isclose
graphix/opengraph.py
Outdated
Comment on lines
452
to
456
| if not nx.utils.graphs_equal(og_1.graph, og_2.graph): | ||
| return False | ||
|
|
||
| if og_1.input_nodes != og_2.input_nodes or og_1.output_nodes != og_2.output_nodes: | ||
| return False |
Collaborator
There was a problem hiding this comment.
Suggested change
| if not nx.utils.graphs_equal(og_1.graph, og_2.graph): | |
| return False | |
| if og_1.input_nodes != og_2.input_nodes or og_1.output_nodes != og_2.output_nodes: | |
| return False | |
| return ( | |
| nx.utils.graphs_equal(og_1.graph, og_2.graph) | |
| and og_1.input_nodes == og_2.input_nodes | |
| and og_1.output_nodes == og_2.output_nodes | |
| ) |
thierry-martinez
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts the existing method
:func: OpenGraph.iscloseto the new API introduced in #358.Additionally, it introduces a new method
:func: OpenGraph.__eq__relevant for open graphs of parametric typegraphix.fundamentals.Planeorgraphix.fundamentals.Axis.