[DRAFT] Add Airspeed velocity support#403
Draft
matulni wants to merge 2 commits intoTeamGraphix:masterfrom
Draft
[DRAFT] Add Airspeed velocity support#403matulni wants to merge 2 commits intoTeamGraphix:masterfrom
matulni wants to merge 2 commits intoTeamGraphix:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 86.11% 86.11%
=======================================
Files 45 45
Lines 6591 6591
=======================================
Hits 5676 5676
Misses 915 915 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces minimal working functionality to support airspeed velocity benchmarking on Graphix.
To benchmark the last two commits, run the following commands on the
asv_benchmarksfolder:Workflow examples
Branch comparison
asv-test@nb.njitdecorator ingraphix._linalg.pyand commit changes. This will remove just-in-time compilation from the Pauli flow-finding algorithms.asv master..asv-testto benchmark the regression of the new branch.asv compare 67c7d26 caab2c00Here,
67c7d26is the last commit inmasterandcaab2c00is the new commit inasv-test.Output reads:
We can pinpoint that the gflow and Pauli-extraction algorithms have worsened! Changes in the other benchmarks are statistical noise.
Profiling
Airspeed velocity has a built-in profiling option based on
cProfile.run
asv profile --gui=snakeviz bench_opengraph.FlowExtraction.time_pauli_flow_rnd_circuit caab2c00to profile the Pauli-flow extraction routine.Note:
--gui=snakevizis an optional flag to visualize the results which requires installingsnakeviz. To do so, runpip install snakeviz.To discuss
This PR is marked as a draft because it's an experimental feature. Here is a (non-exhaustive) list of points to discuss:
Design of sensible benchmarking tests:
Running ASV locally can be useful during the development process, but it may be interesting to showcase the performance of the main branch in the Graphix website. For that: