Skip to content

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Nov 28, 2019

Don't throw exception when hard coded client_id is wrong.
Addresses TeamNewPipe/NewPipe#2823

There is still one problem left: the audioStreamTest fails with a 401 response. Can someone please look into this?

CC @mauriciocolli @Stypox @theScrabi

@TobiGr TobiGr requested a review from mauriciocolli November 28, 2019 23:19
@TobiGr TobiGr added ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug soundcloud service, https://soundcloud.com/ labels Nov 29, 2019
@TobiGr
Copy link
Contributor Author

TobiGr commented Dec 10, 2019

@Stypox What can we do about the 401 response when accessing a stream? With that PR we are just able to view pages, don't ask me why.

Don't throw exception when hard coded client_id is wrong.
Addresses TeamNewPipe/NewPipe#2823
@TobiGr TobiGr changed the base branch from master to dev December 12, 2019 17:05
@TobiGr
Copy link
Contributor Author

TobiGr commented Dec 12, 2019

I am not able to fix the stream issue... That's why I will not prepare a hotfix release and this will be merged to the dev branch

@TobiGr TobiGr merged commit 8cb3250 into dev Dec 12, 2019
@TobiGr TobiGr deleted the fix/SC_client_id branch December 12, 2019 17:11
@pihug12
Copy link
Contributor

pihug12 commented Dec 21, 2019

I saw this fail in the Travis CI log:

Caused by: java.io.IOException: Server returned HTTP response code: 401 for URL: https://api.soundcloud.com/i1/tracks/276206960/streams?client_id=bkcJLoXNaiFlsLaKBQXOxO5FhW0NJVnu

Here are the stream URLs for this track:

https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/extractor/soundcloud.py helped me a bit. I used youtube-dl -s -v --print-traffic https://soundcloud.com/liluzivert/do-what-i-want-produced-by-maaly-raw-don-cannon to see the requests done.

I hope it can help you. :)

@TobiGr
Copy link
Contributor Author

TobiGr commented Dec 21, 2019

Hey @pihug12,
thanks for your help :) I already figured out, that we can need to use the v2 api and how to get no 401 response, but the valid stream. You can find a first, but messy implementation here.
However, the player does not open the stream / m3u file correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug soundcloud service, https://soundcloud.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants