-
-
Notifications
You must be signed in to change notification settings - Fork 512
Fix SoundCloud client_id extraction and update SoundCloud client_id #217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.../src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java
Show resolved
Hide resolved
.../src/main/java/org/schabi/newpipe/extractor/services/soundcloud/SoundcloudParsingHelper.java
Show resolved
Hide resolved
|
@Stypox What can we do about the 401 response when accessing a stream? With that PR we are just able to view pages, don't ask me why. |
Don't throw exception when hard coded client_id is wrong. Addresses TeamNewPipe/NewPipe#2823
34228b3 to
54d1a1a
Compare
|
I am not able to fix the stream issue... That's why I will not prepare a hotfix release and this will be merged to the dev branch |
|
I saw this fail in the Travis CI log: Here are the stream URLs for this track:
https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/extractor/soundcloud.py helped me a bit. I used I hope it can help you. :) |
Don't throw exception when hard coded client_id is wrong.
Addresses TeamNewPipe/NewPipe#2823
There is still one problem left: the audioStreamTest fails with a 401 response. Can someone please look into this?
CC @mauriciocolli @Stypox @theScrabi