Skip to content

Allow PlayLists with missing uploader#219

Merged
TobiGr merged 3 commits intoTeamNewPipe:devfrom
Redirion:patch-1
Dec 12, 2019
Merged

Allow PlayLists with missing uploader#219
TobiGr merged 3 commits intoTeamNewPipe:devfrom
Redirion:patch-1

Conversation

@Redirion
Copy link
Copy Markdown
Member

@Redirion Redirion commented Dec 7, 2019

This supports PR 2724 in NewPipe

For bug description and proposed solution with this pr, see this comment.

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

This supports PR 2724 in NewPipe
@PeterHindes
Copy link
Copy Markdown

Nice I'll test a build with these changes later today.

Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please fix the build. List and ArrayList are not imported. This must be changed before a merge. Otherwise the build will not succeed.

added missing imports
@PeterHindes
Copy link
Copy Markdown

what is the proper way to run a test build with this version of the extractor. Im unfamiliar with gradle.

@Stypox
Copy link
Copy Markdown
Member

Stypox commented Dec 9, 2019

@PeterHindes open up the project in Android Studio and create a new run configuration for Junit 4 tests

@PeterHindes
Copy link
Copy Markdown

I meant building it with the app. I was tryna add it here

@Stypox
Copy link
Copy Markdown
Member

Stypox commented Dec 9, 2019

@PeterHindes follow these steps:

  1. Go to the root build.gradle file (in the project root folder) and add maven { url "https://jitpack.io" } under allprojects { repositories { ... HERE } }
  2. Go to the app build.gradle file (in the app/ subfolder) and add implementation 'com.github.USERNAME:REPO_NAME:FULL_COMMIT_SIGNATURE'. For the latest commit of @Redirion repository it would be implementation 'com.github.Redirion:NewPipeExtractor:cdf41b868c5ea877fd6e1e90688f0d4e95c84a34'.

@PeterHindes
Copy link
Copy Markdown

PeterHindes commented Dec 9, 2019

cool thanks for walking me through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants