Conversation
B0pol
reviewed
Feb 9, 2020
B0pol
reviewed
Feb 9, 2020
Member
|
BTW, in copyright file, the email is chris.schabesberger@mailbox.com, but in every other file, it's chris.schabesberger@mailbox.org |
Member
|
@B0pol you can review all files at once: just press "Start Review" on the first comment and add comments until you are done, then click "Finish your review" |
Member
|
Also, for single-line suggestions you can click on the central button (with a represented file and +-) in the comment toolbar to make a commit-able suggestion |
B0pol
reviewed
Feb 9, 2020
B0pol
reviewed
Feb 9, 2020
Contributor
Author
|
@B0pol Thanks! I'll ask @theScrabi about the email address, but afaik this should be |
Contributor
Author
Stypox
requested changes
Feb 16, 2020
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
Yeah, feel free to merge after committing these small adjustments. Thanks :-D
Co-Authored-By: Stypox <stypox@pm.me>
Stypox
approved these changes
Feb 17, 2020
Member
|
You should close #225 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran IntelliJ's "reformat code" command, but didn't pick all changes.