Conversation
Contributor
|
I had a quick look at it and there's some points to consider:
|
Member
Author
|
We should fix this asap. |
theScrabi
added
ASAP
Member
Author
|
@mauriciocolli @wb9688 I resolved the collision. |
Use content country if supported by SoundCloud
|
@theScrabi: What about:
…Hardcoded type will make it hard to translate it
|
Contributor
|
There are some work to do here, but ok... PS: I think you should have squashed these commits, they messed with the commit history with some useless commits. (instead of clicking |
| public String getUploaderName() { | ||
| return searchResult.getObject("user").getString("username"); | ||
| //return searchResult.getObject("user").getString("username"); | ||
| return searchResult.getObject("track").getObject("user").getString("username"); |
Contributor
There was a problem hiding this comment.
This change didn't considered that both charts and search (and others) use it, therefore, breaking some things.
Member
Author
|
The type should be there to identify the different kiosks (like an Id) it is not there to be translated. We should do the translation on the client side, because otherwise wed have to find a way to make the extractor translatable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add "Kiosk" function
A kiosk can be described as a page that provides content that you don't have to search for, like "top 50" or "trending".
This Pull Request:
The Idea is that with this we can finally get rid of the blank startpage of NewPipe.