Faster iframe api based player extraction.

[FireMasterK]

Uses the IFrame API to reduce the required download to less than 1/50 of the size.

• I carefully read the contribution guidelines and agree to them.
• I have tested the API against NewPipe.
• I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Closes #693?

[XiangRongLin]

Do you have some examples to back up the 1/50 size claim?

[FireMasterK]

Do you have some examples to back up the 1/50 size claim?

Yes, I do, in fact, it's a bit more than that:

[XiangRongLin]

Can you think of a way to somehow automatically test if your new implementation is actually used and it does not just always go to the catch block with the old implementation?

I can't think of anything right away, besides making everything public.

Edit: Reasoning being that the current tests either only cover your new implementation or the old one and not both

[FireMasterK]

What would you like to happen if the new implementation fails?

Printing an error?

I could move them over to two methods so that they can be individually tested.

[XiangRongLin]

What would you like to happen if the new implementation fails?

Printing an error?

Normally i would say log it, but because there is no logging setup => do nothing

I could move them over to two methods so that they can be individually tested.

Yeah that's probably the easiest thing

[FireMasterK]

Done! Another thing I noticed is that the current tests do not account for the fact that the playerCode can be cached, thereby making some tests pointless.

[XiangRongLin]

Can you also add tests for the 2 methods

Another thing I noticed is that the current tests do not account for the fact that the playerCode can be cached, thereby making some tests pointless.

You can create an issue for it. I have a rough idea on how to solve it, but finding the time to do it may prove hard

[FireMasterK]

Done!

[XiangRongLin]

Good enough, since i can't think of anything else either. As in better tests/rewriting for better testability