[YouTube] Consolidate the regular expressions used to find the cipher decryption function#713
Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom Aug 17, 2021
Conversation
Also add more regexes
AudricV
added
bug
Stypox
approved these changes
Aug 14, 2021
Member
Stypox
left a comment
Stypox
left a comment
There was a problem hiding this comment.
The changes look good and the apk works. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See yt-dlp/yt-dlp#641 for more details.
Also use
ADAPTIVE_FORMATSandFORMATSstrings constants instead of the corresponding strings inYoutubeStreamExtractor.Fixes TeamNewPipe/NewPipe#6910
Test APK: app-debug.zip
Note: The extractor in this APK only uses the streams returned on the
WEBclient to check if the decryption of contents protected withsignatureCiphersis working or not.