Add verified info to ChannelInfo.#714
Merged
XiangRongLin merged 1 commit intoTeamNewPipe:devfrom Aug 17, 2021
Merged
Conversation
Member
FireMasterK
commented
Aug 15, 2021
FireMasterK
commented
- I carefully read the contribution guidelines and agree to them.
- I have tested the API against NewPipe.
- I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.
Collaborator
|
Am i seeing it correctly that this is just adding the field and that parsing and filling that field will still need to be done? |
Member
Author
|
They're already parsed in the extractor, I'm just adding it since I don't use extractor/extractions API directly in Piped, but I directly use |
XiangRongLin
approved these changes
Aug 16, 2021
Collaborator
XiangRongLin
left a comment
XiangRongLin
left a comment
There was a problem hiding this comment.
ah, i missed that the class is creating itself with the static methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.