Extract Uploader's Avatar on YouTube and PeerTube#723
Extract Uploader's Avatar on YouTube and PeerTube#723TobiGr merged 5 commits intoTeamNewPipe:devfrom
Conversation
0281832 to
00c8f2e
Compare
|
Thank you @FireMasterK! Could you add some description? Does this add support for channel avatars of stream info items? |
00c8f2e to
b9fad4f
Compare
Done! It indeed does, this currently only works in the Search and Trending pages I believe as YouTube doesn't provide these anywhere else. |
TobiGr
left a comment
There was a problem hiding this comment.
I think this can also be tested roughly in DefaultTests.defaultTestListOfItems().
Please remove throws ParsingException when overriding the method and returning null
abe4ef5 to
c4f32dd
Compare
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
c4f32dd to
db6b3b2
Compare
What about services which in which it's not extracted in? Another thing to note is that even on YouTube, it's not provided everywhere. |
|
Testing this should be similar to testing the thumbnail URL final String uploaderAvatarUrl = item.getUploaderAvatarUrl();
if (!isNullOrEmpty(uploaderAvatarUrl)) {
assertIsSecureUrl(uploaderAvatarUrl);
} |
Added, thanks for the clarification on what you meant! |
This pull request adds support for Channel Avatars extraction in the
StreamInfoItemclass.