Skip to content

Add support for extracting channel subscriber count in StreamInfo#796

Merged
litetex merged 7 commits intoTeamNewPipe:devfrom
FireMasterK:streaminfo-subscriber-count
Mar 14, 2022
Merged

Add support for extracting channel subscriber count in StreamInfo#796
litetex merged 7 commits intoTeamNewPipe:devfrom
FireMasterK:streaminfo-subscriber-count

Conversation

@FireMasterK
Copy link
Copy Markdown
Member

  • I carefully read the contribution guidelines and agree to them.
  • I have tested the API against NewPipe.
  • I agree to create a pull request for NewPipe as soon as possible to make it compatible with the changed API.

Closes #795

@FireMasterK FireMasterK added the YouTube Service, https://www.youtube.com/ label Feb 11, 2022
Copy link
Copy Markdown
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@FireMasterK FireMasterK force-pushed the streaminfo-subscriber-count branch 2 times, most recently from 094861c to 056eae1 Compare February 12, 2022 18:04
Copy link
Copy Markdown
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code improvements

Comment thread extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamExtractor.java Outdated
@FireMasterK FireMasterK force-pushed the streaminfo-subscriber-count branch 2 times, most recently from d67d968 to 59c7298 Compare February 22, 2022 07:19
@FireMasterK FireMasterK force-pushed the streaminfo-subscriber-count branch from 59c7298 to db0c688 Compare February 24, 2022 12:51
@FireMasterK FireMasterK force-pushed the streaminfo-subscriber-count branch from db0c688 to 6950b36 Compare February 24, 2022 12:55
Copy link
Copy Markdown
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you :-)
@litetex merge this once you approve it

Copy link
Copy Markdown
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Only minor codestyle things:

Copy link
Copy Markdown
Member

@litetex litetex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@litetex litetex merged commit 2aa5f98 into TeamNewPipe:dev Mar 14, 2022
@FireMasterK FireMasterK deleted the streaminfo-subscriber-count branch October 30, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

YouTube Service, https://www.youtube.com/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[YouTube] Extract Subscriber Count in StreamInfo

4 participants