Skip to content

Fixed #1548 and #1546 - Playlist links not getting parsed properly #97

Merged
theScrabi merged 3 commits intoTeamNewPipe:masterfrom
MadderRagax:master
Sep 15, 2018
Merged

Fixed #1548 and #1546 - Playlist links not getting parsed properly #97
theScrabi merged 3 commits intoTeamNewPipe:masterfrom
MadderRagax:master

Conversation

@MadderRagax
Copy link
Copy Markdown
Contributor

  • I carefully read the contribution guidelines and agree to them.
  • I did test the API against NewPipe.
  • I agree to ASAP create a PULL request for NewPipe for making in compatible when I changed the api.

Fixed #1548

semi fixed #1546
link such as https://www.youtube.com/watch?v=EYqceb2AnkU&list=PLJbE2Yu2zumDF6BX6_RdPisRVHgzV02NW
Would only land you on the video watch?v=EYqceb2AnkU
Now it adds the entire playlist instead but doesn't remember what video you were on. That would require more changes to send an index as well as the playlist back to new pipe.

@MadderRagax MadderRagax changed the title Fixning #1548 and #1548 - Playlist links not getting parsed properly Fixning #1548 and #1546 - Playlist links not getting parsed properly Jul 25, 2018
@MadderRagax MadderRagax changed the title Fixning #1548 and #1546 - Playlist links not getting parsed properly Fixed #1548 and #1546 - Playlist links not getting parsed properly Jul 25, 2018
@theScrabi
Copy link
Copy Markdown
Member

@MadderRagax thank you :)
Well if we wanted to support a video index as well we'd have to make some deeper changes in the extractor.

@theScrabi
Copy link
Copy Markdown
Member

Code proved so far. I need to test it tho.

@theScrabi
Copy link
Copy Markdown
Member

theScrabi commented Aug 1, 2018

@wb9688 If you have time can you please test this :)

@theScrabi theScrabi merged commit 1e7bcfb into TeamNewPipe:master Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants