feat: mii abstractions#98
Merged
Merged
Conversation
# Conflicts: # WheelWizard/Models/GameData/GameDataPlayer.cs # WheelWizard/Models/RRInfo/RrPlayer.cs # WheelWizard/Services/LiveData/RRLiveRooms.cs # WheelWizard/Services/WiiManagement/SaveData/GameDataLoader.cs
Collaborator
|
This seems to crash WheelWizard on startup if there is no license. Also, using a "no name" Mii, it loads forever now instead of showing the default avatar (at the top) or displaying "no name" on the "My profiles" page (there it also loads forever). |
Member
|
yup. functionality works when you already configured stuff. But a first startup, like adding a |
DirkDoes
requested changes
Apr 3, 2025
Member
DirkDoes
left a comment
DirkDoes
left a comment
There was a problem hiding this comment.
it crashes if there is no Mii to parse
matellush
reviewed
Apr 3, 2025
RubenBroere
requested changes
Apr 4, 2025
Collaborator
RubenBroere
left a comment
RubenBroere
left a comment
There was a problem hiding this comment.
On the right track but still a lot to be improved and bugs to fix.
RubenBroere
requested changes
Apr 6, 2025
DirkDoes
approved these changes
Apr 6, 2025
1 task
RubenBroere
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
This PR is made to change the current Mii implementation to the actual data represented in the mii
How to Test:
Parse mii data through the new system. So just launching the program and seeing everyones mii's
What Has Been Changed:
GameDataLoader and mii manager have been transformed into services
Related Issue Link:
Checklist before merging