Skip to content

Add challenge language endpoints #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mohamed040406 merged 29 commits into from
Oct 19, 2021
Merged

Add challenge language endpoints #60

mohamed040406 merged 29 commits into from
Oct 19, 2021
+828 −44

Conversation

@takos22
Copy link
Contributor

@takos22 takos22 commented Sep 13, 2021

Summary

Add challenge language endpoints, resolves #59.

Checklist

  • If endpoints were changed then they have been documented and tested.
    • I have updated the docmentation to reflect the changes.
    • I have updated the tests to support the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new endpoint or parameter).
  • This PR is a breaking change (e.g. endpoint or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@takos22 takos22 self-assigned this Sep 14, 2021
@takos22 takos22 added the enhancement New feature or request label Sep 14, 2021
@SylteA SylteA changed the title Add challenge language endpoints [Draft] Add challenge language endpoints Sep 14, 2021
@takos22 takos22 marked this pull request as ready for review September 15, 2021 20:55
@takos22 takos22 changed the title [Draft] Add challenge language endpoints Add challenge language endpoints Sep 15, 2021
@takos22 takos22 requested a review from SylteA September 15, 2021 20:55
@takos22 takos22 requested a review from a team September 16, 2021 18:31
@takos22
Fix piston service
ebb549a
@takos22
Pin aiohttp to 3.x
08aa58d 
Because aiohttp 4 is in alpha and gives warnings with pytest
@takos22
Add some tests for challenges
304d216 
Remaining tests will be added in the next few days
@takos22 takos22 added this to the Initial Release milestone Sep 20, 2021
@takos22 takos22 requested review from SylteA and mohamed040406 and removed request for a team and SylteA October 1, 2021 10:32
mohamed040406
mohamed040406 requested changes Oct 1, 2021
View reviewed changes
SylteA
SylteA requested changes Oct 1, 2021
View reviewed changes
SylteA
SylteA reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@SylteA SylteA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also consider changing the filestructure from:

api/versions/v1/routers/challenges/languages/routes.py
api/versions/v1/routers/challenges/routes.py

To something more descriptive like:

api/versions/v1/routers/weekly/challenges/routes.py
api/versions/v1/routers/weekly/languages/routes.py

Just a suggestion.

mohamed040406
mohamed040406 requested changes Oct 8, 2021
View reviewed changes
@takos22 takos22 requested a review from mohamed040406 October 9, 2021 18:11
SylteA
SylteA requested changes Oct 9, 2021
View reviewed changes
@SylteA SylteA requested a review from a team October 17, 2021 08:56
@mohamed040406 mohamed040406 merged commit b37911d into Tech-With-Tim:staging Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SylteA SylteA SylteA approved these changes

@mohamed040406 mohamed040406 mohamed040406 approved these changes

Assignees

@takos22 takos22

Labels

enhancement New feature or request

Projects

None yet

Milestone

Initial Release

Development

Successfully merging this pull request may close these issues.

Challenge Languages

3 participants

@takos22 @SylteA @mohamed040406