build-in-docker.shで毎回setup.sh実行で時間がかかるのでdocker composeを追加#119
Merged
mhidaka merged 1 commit intoTechBooster:masterfrom Feb 1, 2026
Merged
build-in-docker.shで毎回setup.sh実行で時間がかかるのでdocker composeを追加#119mhidaka merged 1 commit intoTechBooster:masterfrom
mhidaka merged 1 commit intoTechBooster:masterfrom
Conversation
4e72cb0 to
932a79c
Compare
mhidaka
approved these changes
Feb 1, 2026
Member
mhidaka
left a comment
There was a problem hiding this comment.
We think this PR will contribute to efficient builds.
If there are any issues, I might ask about it, but so far there are no signs of that happening.
Great Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
テンプレート作成ありがとうございます。
技術書執筆で活用させていただいております。
いつもdockerを使ってbuildをしています。
build-in-docker.shですと、
setup.shでbundle installとnpm installが毎回されて時間がかかってしまいます。
buildのエラー特定のため、頻繁にbuildを回したいのでsetup.shを毎回実行しなくても済むように
docker composeを追加しました。
(現状ですとDocker Desktopにdocker composeも含まれるようになったので、使い勝手は落ちないと思っています。)