Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCpoll fix #1016
Conversation
msmith-techempower
added some commits
Aug 15, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Aug 15, 2014
Contributor
postgresql-server-dev-9.3
If this only needed for this one test, we should put a call to apt-get in the install.sh
If this only needed for this one test, we should put a call to apt-get in the install.sh |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Good point |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Aug 16, 2014
Contributor
This "fixes" cpoll in that it now compiles and runs correctly. It does have some minor validation errors (json array instead of dict sort of things). Let me know if you want to fix those with this PR, or if we should merge this into master as "better than current"
|
This "fixes" cpoll in that it now compiles and runs correctly. It does have some minor validation errors (json array instead of dict sort of things). Let me know if you want to fix those with this PR, or if we should merge this into master as "better than current" |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
msmith-techempower
Aug 18, 2014
Member
@hamiltont is Travis treating both errors and warnings as failure state? It should just be errors, correct?
EDIT: ugh, morning. Accidentally hit "close and comment"
|
@hamiltont is Travis treating both errors and warnings as failure state? It should just be errors, correct? EDIT: ugh, morning. Accidentally hit "close and comment" |
msmith-techempower
closed this
Aug 18, 2014
msmith-techempower
reopened this
Aug 18, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Aug 18, 2014
Contributor
errors and warnings as failure state
To nitpick on terminology for a second - travis only reports errors or failures. You can print warnings all day and they don't care - only the return status is important. Failure and Error both indicate a non-zero return status from some line listed in the .travis.yml (a failure if the offender is under the script category, else an error). An error for any job marks the build as error. A failure for any job marks the build as fail.
The main source of our errors at the moment is #989 . In fact, if you just "restart" the errored jobs, they will normally launch without these network issues, complete without incident, and the entire travis build will then be marked properly.
To nitpick on terminology for a second - travis only reports errors or failures. You can print warnings all day and they don't care - only the return status is important. Failure and Error both indicate a non-zero return status from some line listed in the The main source of our |
msmith-techempower commentedAug 15, 2014
The
CPLUS_INCLUDE_PATHis definitely needed.As for using
postgresql-server-dev-9.3- this might not work on Ubuntu 12 - we shall find out.