Cpoll fix

[msmith-techempower]

The CPLUS_INCLUDE_PATH is definitely needed.

As for using postgresql-server-dev-9.3 - this might not work on Ubuntu 12 - we shall find out.

[hamiltont]

postgresql-server-dev-9.3

If this only needed for this one test, we should put a call to apt-get in the install.sh

[hamiltont]

postgresql-server-dev-9.3

If this only needed for this one test, we should put a call to apt-get in the install.sh

[msmith-techempower]

Good point

[msmith-techempower]

Good point

[hamiltont]

This "fixes" cpoll in that it now compiles and runs correctly. It does have some minor validation errors (json array instead of dict sort of things). Let me know if you want to fix those with this PR, or if we should merge this into master as "better than current"

[hamiltont]

This "fixes" cpoll in that it now compiles and runs correctly. It does have some minor validation errors (json array instead of dict sort of things). Let me know if you want to fix those with this PR, or if we should merge this into master as "better than current"

[msmith-techempower]

@hamiltont is Travis treating both errors and warnings as failure state? It should just be errors, correct?

EDIT: ugh, morning. Accidentally hit "close and comment"

[msmith-techempower]

@hamiltont is Travis treating both errors and warnings as failure state? It should just be errors, correct?

EDIT: ugh, morning. Accidentally hit "close and comment"

[hamiltont]

errors and warnings as failure state

To nitpick on terminology for a second - travis only reports errors or failures. You can print warnings all day and they don't care - only the return status is important. Failure and Error both indicate a non-zero return status from some line listed in the .travis.yml (a failure if the offender is under the script category, else an error). An error for any job marks the build as error. A failure for any job marks the build as fail.

The main source of our errors at the moment is #989 . In fact, if you just "restart" the errored jobs, they will normally launch without these network issues, complete without incident, and the entire travis build will then be marked properly.

[hamiltont]

errors and warnings as failure state

To nitpick on terminology for a second - travis only reports errors or failures. You can print warnings all day and they don't care - only the return status is important. Failure and Error both indicate a non-zero return status from some line listed in the .travis.yml (a failure if the offender is under the script category, else an error). An error for any job marks the build as error. A failure for any job marks the build as fail.

The main source of our errors at the moment is #989 . In fact, if you just "restart" the errored jobs, they will normally launch without these network issues, complete without incident, and the entire travis build will then be marked properly.