Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for Oracle Java 8 #1080
Conversation
hamiltont
reviewed
Sep 6, 2014
| @@ -0,0 +1,20 @@ | ||
| #!/bin/bash | ||
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Sep 6, 2014
Contributor
Could you add the standard RETCODE bit, so that back-to-back calls of this file don't cause fairly large delays while we re-run apt-get for no reason.
Note: Instead of return 0, you need to run update-alternatives and then return 0
hamiltont
Sep 6, 2014
Contributor
Could you add the standard RETCODE bit, so that back-to-back calls of this file don't cause fairly large delays while we re-run apt-get for no reason.
Note: Instead of return 0, you need to run update-alternatives and then return 0
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Sep 6, 2014
Contributor
Looks exciting! I've asked for some minor changes above. In addition, could you also
- Add a small README here explaining that Java-based framewroks can use either
fw_depends java(for orackel java 7) orfw_depends java8for oracle java 8. Explain what the binaries are called (e.g. for java 7 most people call thejavabinary, should they do the same for java 8 or is it named differently?) - Update java.sh to run
update-alternativesand switch back to java-7 if necessary - Is there any java-based framework you feel comfortable updating to java8? That way we could see if Travis-CI green-lights these changes
I'm very glad to see this being added!
|
Looks exciting! I've asked for some minor changes above. In addition, could you also
I'm very glad to see this being added! |
marko-asplund
added some commits
Sep 6, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marko-asplund
Sep 8, 2014
Contributor
@hamiltont AFAIK, I think this PR should be ok now.
I updated servlet3-cass in my local dev env to use java8. The tests seemed to be fine, but then I ran into some problems with Travis CI (see #1082) before committing these changes. I need to figure out what's causing the CI build to fail before updating the test implementation for Java 8.
|
@hamiltont AFAIK, I think this PR should be ok now. I updated servlet3-cass in my local dev env to use java8. The tests seemed to be fine, but then I ran into some problems with Travis CI (see #1082) before committing these changes. I need to figure out what's causing the CI build to fail before updating the test implementation for Java 8. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Sep 8, 2014
Contributor
Cool. I'm out for the next few months, have a degree to prioritize. One of
the TE team can check this for you
|
Cool. I'm out for the next few months, have a degree to prioritize. One of |
marko-asplund
added some commits
Sep 14, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marko-asplund
Oct 17, 2014
Contributor
@hamiltont Java 8 PR updated and merged with latest upstream master branch.
|
@hamiltont Java 8 PR updated and merged with latest upstream master branch. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Oct 17, 2014
Contributor
Cool, let's see what Travis has to say about it!
Note to self: see here
|
Cool, let's see what Travis has to say about it! Note to self: see here |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marko-asplund
Oct 17, 2014
Contributor
This PR just adds a README + Java 8 installations script, so Travis shouldn't fail due to this. While I've tested this in my development sandbox and it seems to work, no test implementations have been updated to use Java 8, yet. I'm planning to do this as part of a separate PR.
|
This PR just adds a README + Java 8 installations script, so Travis shouldn't fail due to this. While I've tested this in my development sandbox and it seems to work, no test implementations have been updated to use Java 8, yet. I'm planning to do this as part of a separate PR. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Oct 17, 2014
Contributor
Oh, ok. Then there's nothing to wait on for this PR I guess. Visual inspection LGTM, I'll go ahead and merge this and look forward to a PR actually using it
|
Oh, ok. Then there's nothing to wait on for this PR I guess. Visual inspection LGTM, I'll go ahead and merge this and look forward to a PR actually using it |
added a commit
that referenced
this pull request
Oct 17, 2014
hamiltont
merged commit 2a7b21f
into
TechEmpower:master
Oct 17, 2014
1 check was pending
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marko-asplund
Oct 17, 2014
Contributor
great, thanks!
Issue #1048 is basically a duplicate of this, so it can be closed as well.
(this one was created because I couldn't figure how to associate my PR with the existing issue)
|
great, thanks! Issue #1048 is basically a duplicate of this, so it can be closed as well. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Oct 17, 2014
Contributor
@marko-asplund just to be clear, there's no reason that a framework cannot use fw_depends java java8 to install both, and then just use a full path to the binary they want, right?
Perhaps we should add that to the readme, or I predict a lot of duplicated folders (e.g. java-stuffand java-stuff-java8)
|
@marko-asplund just to be clear, there's no reason that a framework cannot use Perhaps we should add that to the readme, or I predict a lot of duplicated folders (e.g. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
marko-asplund
Oct 17, 2014
Contributor
Yes, that should be totally ok.
The Java 8 installation script tries hard to retain OpenJDK 7 as the default instead of Oracle JDK 8.
|
Yes, that should be totally ok. |
marko-asplund commentedSep 6, 2014
issue #1048