Add support for Oracle Java 8#1080
Conversation
There was a problem hiding this comment.
Could you add the standard RETCODE bit, so that back-to-back calls of this file don't cause fairly large delays while we re-run apt-get for no reason.
Note: Instead of return 0, you need to run update-alternatives and then return 0
|
Looks exciting! I've asked for some minor changes above. In addition, could you also
I'm very glad to see this being added! |
|
@hamiltont AFAIK, I think this PR should be ok now. I updated servlet3-cass in my local dev env to use java8. The tests seemed to be fine, but then I ran into some problems with Travis CI (see #1082) before committing these changes. I need to figure out what's causing the CI build to fail before updating the test implementation for Java 8. |
|
Cool. I'm out for the next few months, have a degree to prioritize. One of |
… changed package contents
Conflicts: toolset/setup/linux/prerequisites.sh
|
@hamiltont Java 8 PR updated and merged with latest upstream master branch. |
|
Cool, let's see what Travis has to say about it! Note to self: see here |
|
This PR just adds a README + Java 8 installations script, so Travis shouldn't fail due to this. While I've tested this in my development sandbox and it seems to work, no test implementations have been updated to use Java 8, yet. I'm planning to do this as part of a separate PR. |
|
Oh, ok. Then there's nothing to wait on for this PR I guess. Visual inspection LGTM, I'll go ahead and merge this and look forward to a PR actually using it |
Java: Add support for Oracle Java 8
|
great, thanks! Issue #1048 is basically a duplicate of this, so it can be closed as well. |
|
@marko-asplund just to be clear, there's no reason that a framework cannot use Perhaps we should add that to the readme, or I predict a lot of duplicated folders (e.g. |
|
Yes, that should be totally ok. |
issue #1048