[Dart] fix dart3_aot regression (2)#10852
Open
iapicca wants to merge 4 commits intoTechEmpower:masterfrom
Open
[Dart] fix dart3_aot regression (2)#10852iapicca wants to merge 4 commits intoTechEmpower:masterfrom
iapicca wants to merge 4 commits intoTechEmpower:masterfrom
Conversation
Contributor
|
The following frameworks were updated, pinging maintainers: |
iapicca
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10835
This PR fixes two issues that were silently preventing worker isolates from scaling correctly in AOT mode:
Dockerfile misconfiguration: Fixed an issue where the AOT snapshot wasn't being executed properly, preventing the isolate scaling logic from triggering.
Dart runtime crash: Fixed a silent crash in the worker processes. The VM passes command-line arguments as a fixed-length list, which caused an UnsupportedError when the child isolates tried to remove the _workerGroup flag. The arguments are now safely copied into a mutable list ([...arguments]) before modification.