New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Yesod and WAI #1086

Merged
merged 5 commits into from Oct 7, 2014

Conversation

Projects
None yet
2 participants
@snoyberg
Contributor

snoyberg commented Oct 7, 2014

This brings WAI forward to use GHC 7.8, just like Yesod does now. It also introduces some performance enhancements to the Yesod implementation, and reduces the library dependencies in Yesod to get faster compile times (it originally used the yesod package, when in reality just yesod-core was necessary).

One possibly contentious change is: 062e4f9. @kazu-yamamoto and I discussed this, and weren't completely certain if the thread count passed in should be treated as a hard limit on the number of machine cores to use or not. This commit changes it so that the benchmarks will use exactly the number of threads specified, regardless of the number of cores actually available. The previous behavior was to use all cores reported available by the OS.

snoyberg added some commits Oct 7, 2014

Some Yesod cleanup/optimization
* Use sendWaiResponse
* Simplify the Mongo code to avoid persistent-mongoDB
* Avoid InternalState acquisition
* Use runInUnboundThread for Yesod
@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Oct 7, 2014

Member

@snoyberg Looks like Travis is content with this; is it ready to be merged?

Related: in #832 I discussed some preliminary results when twiddling with the dials. The best results we saw were with +RTS -N -qg2; changing -N to specify the thread count might have slightly lowered the results, but I don't recall and I didn't say that specifically in that post.

Member

msmith-techempower commented Oct 7, 2014

@snoyberg Looks like Travis is content with this; is it ready to be merged?

Related: in #832 I discussed some preliminary results when twiddling with the dials. The best results we saw were with +RTS -N -qg2; changing -N to specify the thread count might have slightly lowered the results, but I don't recall and I didn't say that specifically in that post.

@snoyberg

This comment has been minimized.

Show comment
Hide comment
@snoyberg

snoyberg Oct 7, 2014

Contributor

@msmith-techempower The only thing to be careful about is the explicit core count. Can I leave it to your discretion whether that commit gets merged in or not? Otherwise, this is definitely good to go.

Contributor

snoyberg commented Oct 7, 2014

@msmith-techempower The only thing to be careful about is the explicit core count. Can I leave it to your discretion whether that commit gets merged in or not? Otherwise, this is definitely good to go.

msmith-techempower added a commit that referenced this pull request Oct 7, 2014

Merge pull request #1086 from snoyberg/master
Updates to Yesod and WAI
LGTM!

@msmith-techempower msmith-techempower merged commit b26be29 into TechEmpower:master Oct 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment