Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Updates to Yesod and WAI#1086

Merged
msmith-techempower merged 5 commits intoTechEmpower:masterfrom
snoyberg:master
Oct 7, 2014
Merged

Updates to Yesod and WAI#1086
msmith-techempower merged 5 commits intoTechEmpower:masterfrom
snoyberg:master

Conversation

@snoyberg
Copy link
Copy Markdown
Contributor

@snoyberg snoyberg commented Oct 7, 2014

This brings WAI forward to use GHC 7.8, just like Yesod does now. It also introduces some performance enhancements to the Yesod implementation, and reduces the library dependencies in Yesod to get faster compile times (it originally used the yesod package, when in reality just yesod-core was necessary).

One possibly contentious change is: 062e4f9. @kazu-yamamoto and I discussed this, and weren't completely certain if the thread count passed in should be treated as a hard limit on the number of machine cores to use or not. This commit changes it so that the benchmarks will use exactly the number of threads specified, regardless of the number of cores actually available. The previous behavior was to use all cores reported available by the OS.

* Use sendWaiResponse
* Simplify the Mongo code to avoid persistent-mongoDB
* Avoid InternalState acquisition
* Use runInUnboundThread for Yesod
@msmith-techempower
Copy link
Copy Markdown
Member

@snoyberg Looks like Travis is content with this; is it ready to be merged?

Related: in #832 I discussed some preliminary results when twiddling with the dials. The best results we saw were with +RTS -N -qg2; changing -N to specify the thread count might have slightly lowered the results, but I don't recall and I didn't say that specifically in that post.

@snoyberg
Copy link
Copy Markdown
Contributor Author

snoyberg commented Oct 7, 2014

@msmith-techempower The only thing to be careful about is the explicit core count. Can I leave it to your discretion whether that commit gets merged in or not? Otherwise, this is definitely good to go.

msmith-techempower added a commit that referenced this pull request Oct 7, 2014
Updates to Yesod and WAI
LGTM!
@msmith-techempower msmith-techempower merged commit b26be29 into TechEmpower:master Oct 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants