This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Updates to Yesod and WAI#1086
Merged
msmith-techempower merged 5 commits intoTechEmpower:masterfrom Oct 7, 2014
Merged
Conversation
* Use sendWaiResponse * Simplify the Mongo code to avoid persistent-mongoDB * Avoid InternalState acquisition * Use runInUnboundThread for Yesod
Pinging @kazu-yamamoto does this make sense to you?
Member
|
@snoyberg Looks like Travis is content with this; is it ready to be merged? Related: in #832 I discussed some preliminary results when twiddling with the dials. The best results we saw were with |
Contributor
Author
|
@msmith-techempower The only thing to be careful about is the explicit core count. Can I leave it to your discretion whether that commit gets merged in or not? Otherwise, this is definitely good to go. |
msmith-techempower
added a commit
that referenced
this pull request
Oct 7, 2014
Updates to Yesod and WAI LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings WAI forward to use GHC 7.8, just like Yesod does now. It also introduces some performance enhancements to the Yesod implementation, and reduces the library dependencies in Yesod to get faster compile times (it originally used the yesod package, when in reality just yesod-core was necessary).
One possibly contentious change is: 062e4f9. @kazu-yamamoto and I discussed this, and weren't completely certain if the thread count passed in should be treated as a hard limit on the number of machine cores to use or not. This commit changes it so that the benchmarks will use exactly the number of threads specified, regardless of the number of cores actually available. The previous behavior was to use all cores reported available by the OS.