Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Fix zend framework 2 db multi queries should default to min/max 1/500#1148

Merged
hamiltont merged 1 commit intoTechEmpower:masterfrom
gerardroche:zf2-fix-db-multi
Oct 30, 2014
Merged

Fix zend framework 2 db multi queries should default to min/max 1/500#1148
hamiltont merged 1 commit intoTechEmpower:masterfrom
gerardroche:zf2-fix-db-multi

Conversation

@gerardroche
Copy link
Copy Markdown
Contributor

@msmith-techempower
Copy link
Copy Markdown
Member

This looks fine, but there are still some warnings in the travis output: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/39345008

I can merge now, or you can commit more fixes.

@gerardroche
Copy link
Copy Markdown
Contributor Author

What exactly are the warnings for? My guess is that it's because the json should have integer values rather than string integers. If this the case I say merge it as is because this is how 90+% of zf users would encode json using the framework.

The Zend Framework version 1of these benchmarks displays the same watnings too, so same as above. #874

@hamiltont
Copy link
Copy Markdown
Contributor

My guess is that it's because the json should have integer values rather than string integers

Correct, that's the only thing it's warning about. This LGTM

@hamiltont
Copy link
Copy Markdown
Contributor

For what it's worth, the warning is not being issued because TFB developers have some preferred representation of numbers in JSON - it's warning you because this might cause your framework to bump up against the physical limits of the networking hardware, as the quotation marks consume a few extra bytes per request.

If this is the natural JSON representation for zend I would totally ignore these warnings, unless Zend gets the top 2 or 3 spot in the preview data for the next round (then definitely optimize it and go for one!)

hamiltont added a commit that referenced this pull request Oct 30, 2014
PHP: Fix zend framework 2 min/max 1/500
@hamiltont hamiltont merged commit 7064c54 into TechEmpower:master Oct 30, 2014
@hamiltont
Copy link
Copy Markdown
Contributor

LGTM, thanks again @gerardroche !

@gerardroche gerardroche mentioned this pull request Apr 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants