Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix zend framework 2 db multi queries should default to min/max 1/500 #1148
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
msmith-techempower
Oct 29, 2014
Member
This looks fine, but there are still some warnings in the travis output: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/39345008
I can merge now, or you can commit more fixes.
|
This looks fine, but there are still some warnings in the travis output: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/39345008 I can merge now, or you can commit more fixes. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
gerardroche
Oct 30, 2014
Contributor
What exactly are the warnings for? My guess is that it's because the json should have integer values rather than string integers. If this the case I say merge it as is because this is how 90+% of zf users would encode json using the framework.
The Zend Framework version 1of these benchmarks displays the same watnings too, so same as above. #874
|
What exactly are the warnings for? My guess is that it's because the json should have integer values rather than string integers. If this the case I say merge it as is because this is how 90+% of zf users would encode json using the framework. The Zend Framework version 1of these benchmarks displays the same watnings too, so same as above. #874 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Oct 30, 2014
Contributor
My guess is that it's because the json should have integer values rather than string integers
Correct, that's the only thing it's warning about. This LGTM
Correct, that's the only thing it's warning about. This LGTM |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Oct 30, 2014
Contributor
For what it's worth, the warning is not being issued because TFB developers have some preferred representation of numbers in JSON - it's warning you because this might cause your framework to bump up against the physical limits of the networking hardware, as the quotation marks consume a few extra bytes per request.
If this is the natural JSON representation for zend I would totally ignore these warnings, unless Zend gets the top 2 or 3 spot in the preview data for the next round (then definitely optimize it and go for one!)
|
For what it's worth, the warning is not being issued because TFB developers have some preferred representation of numbers in JSON - it's warning you because this might cause your framework to bump up against the physical limits of the networking hardware, as the quotation marks consume a few extra bytes per request. If this is the natural JSON representation for zend I would totally ignore these warnings, unless Zend gets the top 2 or 3 spot in the preview data for the next round (then definitely optimize it and go for one!) |
added a commit
that referenced
this pull request
Oct 30, 2014
hamiltont
merged commit 7064c54
into
TechEmpower:master
Oct 30, 2014
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
LGTM, thanks again @gerardroche ! |
gerardroche commentedOct 29, 2014
See #874 (comment)