Fix zend framework 2 db multi queries should default to min/max 1/500#1148
Fix zend framework 2 db multi queries should default to min/max 1/500#1148hamiltont merged 1 commit intoTechEmpower:masterfrom gerardroche:zf2-fix-db-multi
Conversation
|
This looks fine, but there are still some warnings in the travis output: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/39345008 I can merge now, or you can commit more fixes. |
|
What exactly are the warnings for? My guess is that it's because the json should have integer values rather than string integers. If this the case I say merge it as is because this is how 90+% of zf users would encode json using the framework. The Zend Framework version 1of these benchmarks displays the same watnings too, so same as above. #874 |
Correct, that's the only thing it's warning about. This LGTM |
|
For what it's worth, the warning is not being issued because TFB developers have some preferred representation of numbers in JSON - it's warning you because this might cause your framework to bump up against the physical limits of the networking hardware, as the quotation marks consume a few extra bytes per request. If this is the natural JSON representation for zend I would totally ignore these warnings, unless Zend gets the top 2 or 3 spot in the preview data for the next round (then definitely optimize it and go for one!) |
PHP: Fix zend framework 2 min/max 1/500
|
LGTM, thanks again @gerardroche ! |
See #874 (comment)