Dropwizard/plaintext resource now returning precomputed byte array

[zloster]

This could be considered as a performance optimisation. It is similar to the plaintext implementation with undertow/undertow-edge. Obviously without the NIO optimisation.

[hamiltont]

Would you be interested in updating this to fix these remaining issues:

INFO:run-ci:   WARN for http://127.0.0.1:9000/db?queries=0
INFO:run-ci:     JSON array length of 0 != expected length of 1
INFO:run-ci:   FAIL for http://127.0.0.1:9000/db?queries=foo
INFO:run-ci:     Empty Response
INFO:run-ci:   FAIL for http://127.0.0.1:9000/db?queries=501
INFO:run-ci:     JSON array length of 501 != expected length of 500

Note for @msmith-techempower - @zloster didn't add any new failures here, but the new verification checks are detecting failures that we were not looking for before. In short, we can safely merge this PR as is if @zloster does not want to fix the remaining issues.

[hamiltont]

Would you be interested in updating this to fix these remaining issues:

INFO:run-ci:   WARN for http://127.0.0.1:9000/db?queries=0
INFO:run-ci:     JSON array length of 0 != expected length of 1
INFO:run-ci:   FAIL for http://127.0.0.1:9000/db?queries=foo
INFO:run-ci:     Empty Response
INFO:run-ci:   FAIL for http://127.0.0.1:9000/db?queries=501
INFO:run-ci:     JSON array length of 501 != expected length of 500

Note for @msmith-techempower - @zloster didn't add any new failures here, but the new verification checks are detecting failures that we were not looking for before. In short, we can safely merge this PR as is if @zloster does not want to fix the remaining issues.

[zloster]

@hamiltont I'll try to fix the things.

[zloster]

@hamiltont I'll try to fix the things.

[hamiltont]

Great!

On Wed, Oct 29, 2014, 7:38 PM Radoslav Petrov notifications@github.com
wrote:

@hamiltont https://github.com/hamiltont I'll try to fix the things.

—
Reply to this email directly or view it on GitHub
#1150 (comment)
.

[hamiltont]

Great!

On Wed, Oct 29, 2014, 7:38 PM Radoslav Petrov notifications@github.com
wrote:

@hamiltont https://github.com/hamiltont I'll try to fix the things.

—
Reply to this email directly or view it on GitHub
#1150 (comment)
.

[msmith-techempower]

@hamiltont Why are ?queries=foo and ?queries=501 giving fails and not warnings?
Subtext: they should be warnings and not failures for this round.

[msmith-techempower]

@hamiltont Why are ?queries=foo and ?queries=501 giving fails and not warnings?
Subtext: they should be warnings and not failures for this round.

[zloster]

@hamiltont @msmith-techempower The response validation problems seems to be addressed in the following pull request

[zloster]

@hamiltont @msmith-techempower The response validation problems seems to be addressed in the following pull request

[zloster]

I've merged the updated pull request from master.

[zloster]

I've merged the updated pull request from master.