Skip to content

Conversation

@marko-asplund
Copy link
Contributor

Set Cassandra listen_address and rpc_address param values during installation #1382

@marko-asplund
Copy link
Contributor Author

@msmith-techempower @hamiltont This is a bug fix only PR that should take care of the Cassandra installation problems. Please review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd vote to use export e.g. l.append("export %s=%s" % (k,v)) - there's not much security risk and it ensures that even if there's a future change this variable will always be available

@hamiltont
Copy link
Contributor

This LGTM. Mike mentioned in IRC that he's hoping to not take any more PRs, so I'm not sure if it's going to go in before R10

@marko-asplund
Copy link
Contributor Author

@hamiltont I updated this PR to address your review comments.

@msmith-techempower I re-checked this PR after the change in a Vagrant development environment and it seems to work as before. Please consider merging this fix for R10.

@msmith-techempower
Copy link
Member

We need this to work before R10 as cassandra is still giving us trouble.

msmith-techempower added a commit that referenced this pull request Mar 11, 2015
Set Cassandra listen_address and rpc_address
@msmith-techempower msmith-techempower merged commit fd3655a into TechEmpower:master Mar 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants