New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase throughput for Grizzly and undertow by parallelizing DB access #1439

Merged
merged 7 commits into from Apr 4, 2015

Conversation

Projects
None yet
2 participants
@denkab
Contributor

denkab commented Mar 24, 2015

  1. Original configuration of connection for Hibernate in Grizzly-Jersey was highly inadequate. Bumped connection count to match claimed parallelism of test framework (256).
  2. Parallelized DB operations for Grizzly-Jersey and undertow

@LadyMozzarella LadyMozzarella added this to the Round 11 milestone Mar 24, 2015

@denkab

This comment has been minimized.

Show comment
Hide comment
@denkab

denkab Mar 26, 2015

Contributor

Can not reproduce Mongo failure in my set up where I run it in a VirtualBox VM with 4 GB allocated. If I run the service by "./setup.sh" and then hit it with request, it returns just fine. If I run full blown test, the test terminates and the terminal session is "Connection to 127.0.0.1 closed by remote host."

Not my fault? :o)

Contributor

denkab commented Mar 26, 2015

Can not reproduce Mongo failure in my set up where I run it in a VirtualBox VM with 4 GB allocated. If I run the service by "./setup.sh" and then hit it with request, it returns just fine. If I run full blown test, the test terminates and the terminal session is "Connection to 127.0.0.1 closed by remote host."

Not my fault? :o)

@LadyMozzarella

This comment has been minimized.

Show comment
Hide comment
@LadyMozzarella

LadyMozzarella Mar 26, 2015

Member

All of the mongodb tests tend to fail in Travis-CI. I ran your branch on the tests you changed through vagrant and it all looks good to me.

undertowgrizzlyverify

Member

LadyMozzarella commented Mar 26, 2015

All of the mongodb tests tend to fail in Travis-CI. I ran your branch on the tests you changed through vagrant and it all looks good to me.

undertowgrizzlyverify

new Callable<World>() {
@Override
public World call() throws Exception {
return (World) accessor.load(random.nextInt(DB_ROWS) + 1);

This comment has been minimized.

@LadyMozzarella

LadyMozzarella Apr 2, 2015

Member

It appears that this method (IdentifierLoadAccess.load) could potentially be returning the data from a cache based off of this description from the Hibernate JavaDoc:

If the instance is already associated with the session, return that instance, initializing it if needed.

This sounds like it could be a cache. If this is the case, we would need to ensure that it makes direct database access. Do you mind providing some clarification?

@LadyMozzarella

LadyMozzarella Apr 2, 2015

Member

It appears that this method (IdentifierLoadAccess.load) could potentially be returning the data from a cache based off of this description from the Hibernate JavaDoc:

If the instance is already associated with the session, return that instance, initializing it if needed.

This sounds like it could be a cache. If this is the case, we would need to ensure that it makes direct database access. Do you mind providing some clarification?

@denkab

This comment has been minimized.

Show comment
Hide comment
@denkab

denkab Apr 3, 2015

Contributor

For query cache to work it needs to be enabled. Whomever first introduced this framework upheld the benchmark contract by supplying Hibernate configuration:
<property name="hibernate.cache.use_query_cache">false</property>

Contributor

denkab commented Apr 3, 2015

For query cache to work it needs to be enabled. Whomever first introduced this framework upheld the benchmark contract by supplying Hibernate configuration:
<property name="hibernate.cache.use_query_cache">false</property>

@LadyMozzarella LadyMozzarella self-assigned this Apr 3, 2015

LadyMozzarella added a commit that referenced this pull request Apr 4, 2015

Merge pull request #1439 from denkab/master
Increase throughput for Grizzly and undertow by parallelizing DB access

@LadyMozzarella LadyMozzarella merged commit ce09e84 into TechEmpower:master Apr 4, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment