Do not apt-get upgrade

[hamiltont]

Increases stability of our scripts by avoiding unexpected upgrades

Fixes #1369
Fixes #1139

[msmith-techempower]

Will this leave us in the 'never ran upgrade' position?

[hamiltont]

More like a "Only run upgrade manually" situation - the problem is that automatic upgrade of all software on the machine has big implications, and often creates complex problems. This upgrade has causes issues in Travis with mongodb, rsyslog, and postgres, and they are annoyingly complex issues (like upgrade seems to re-install the postgres version that we expressly uninstalled, then try and start it, which fails because an older version is running or something crazy like that)

[hamiltont]

Basically, if a human is there to understand what to do when apt-get upgrade fails and dpkg starts refusing to do anything more, then sure you can upgrade. Otherwise....it's a PITA

[LadyMozzarella]

Travis build - not yet started as of this commit.

[hamiltont]

This one was actually scheduled correctly on the main queue. I think a lot of them were (see here) they just were not hyperlinked from the pull requests because travis didn't have write permission on the organization

[LadyMozzarella]

whoops- thanks @hamiltont

[hamiltont]

So travis finished, and the only two differences from the latest full build on master are Haskell/yesod and JavaScript/nodejs. NodeJS started passing (yay!), and yesod started failing with this:

attoparsec-0.12.1.5 failed during the building phase. The exception was:
ExitFailure 9
This may be due to an out-of-memory condition.
bench-0.0.0 depends on attoparsec-0.12.1.5 which failed to install.

Scala/scruffy started failing, but that turns out to actually be true (master just hadn't caught up to the failure yet - see #1481).

I'm hoping to merge this, thoughts?

[hamiltont]

As an added bonus, this drops about 2 hours off the total travis build time :-P

[msmith-techempower]

cabal (the package manager for haskell) often runs out of memory in the Travis environment. I would suggest pulling and testing on a VM with a bit more RAM and proving it is a false-positive.

[methane]

@msmith-techempower See #1117

[hamiltont]

Sadly, I have confirmed that yesod is indeed broken in master, and that is not just an effect of removing apt-get upgrade. Confirmed via travis and virtualbox.

So the only test affected by this PR appears to be nodejs, which now passes.