Update: Remove bash profile, Closes #1314 by replacement#1478
Update: Remove bash profile, Closes #1314 by replacement#1478hamiltont merged 99 commits intoTechEmpower:masterfrom
Conversation
|
PHP tests are failing for me right now (hence the postpone label). Will look into issue tomorrow, but want to get an idea of what all needs to be fixed up for a merge. :) |
frameworks/C++/wt/setup_postgres.sh
Outdated
There was a problem hiding this comment.
Please add this comment back - it is important to note that certain special variables are not visible here (such as PATH, LD_LIBRARY_PATH, etc)
…rerequsites clean up lapis exports
- Make minor adjustments after merge conflict, clean up - Load the benchmark_profile again - Move llvm-dev installation to sudo apt-get group - Set default location of PHP for composer. - Export JAVA_HOME where sbt is used - This is the 3rd commit message: - Add removed comments with guidance back in - This is the 4th commit message: - Use COMPOSER_HOME and make it consistent - This is the 5th commit message: - Export URWEB_HOME - Add missing export for C++/wt postgres - Move exports from bash_profile for Python/pyramid
LadyMozzarella
force-pushed
the
lgratrix-remove-bash-profile
branch
from
50fd114 to
282bec9
Compare
|
This PR is a beast. I think he's updated pretty well now. I also think I've covered all of the comments you guys have left. If you see anything wild in there, please let me know. I'd like to try and get this one merged in ASAP because it's crazy large and merge conflicts so easy. Hopefully this Travis run is on point. |
|
I've read it carefully - it appears totally correct to me at this point, so I'm good to merge even if there's one minor regression somewhere |
bash_profile contents placed into install files and setup files for: - API-Hour - Cherrypy - Django
|
Okay. I looked over the Travis output and found that there were three python frameworks added after Lita made her commits (thank you, Travis!), so I updated those to remove their bash_profiles. There were also three that were breaking and I think it's just because some of the exports were needed in either certain install or setup scripts. Overall, it appeared that those were the only ones that were breaking on the last Travis run. Frameworks that I'm paying attention to:
I've taken notes on which ones broke the last round on Travis, so I'm prepared to fix those up if there are further problems after merge - or we can wait for this next run on Travis. :) |
|
My vote is to merge away - it's inevitable that one or two will hiccup with
a change this big :-p
|
|
Looks like they're all good except C++/wt in the last run. Do you mind doing the merge @hamiltont? :) |
…file Toolset: Remove bash_profile.sh
4 participants
Replacement for #1314
Updates made based off of comments made on #1314 on top of @lgratrix-techempower's commits.