Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Improve hapi framework#1649

Merged
msmith-techempower merged 7 commits intoTechEmpower:masterfrom
zane-techempower:improve-hapi
Jun 10, 2015
Merged

Improve hapi framework#1649
msmith-techempower merged 7 commits intoTechEmpower:masterfrom
zane-techempower:improve-hapi

Conversation

@zane-techempower
Copy link
Copy Markdown
Contributor

This PR covers:

  • Improve hapi's organization w.r.t. handlers for each database set up
  • Update dependencies to newest version
  • Sequelize (mysql, postgres) uses Promises now
  • Add Postgres and Redis tests
  • Promisified the redis library so now that uses a Promise approach rather than async
  • Promisify mongodb handler
  • Improve start up time -- server takes about a minute between when the master cluster forks and all the workers are up and ready. I was able to do a slight optimization that dropped the time by a second, but I was not able to determine the cause of the long delay.
  • Add band-aid fix of adding sleep 30 to the setup.sh to give more time.

@zane-techempower
Copy link
Copy Markdown
Contributor Author

Took a look at travis. The fails are non-hapi related.

Crystal/moonshine, Rust/iron, and Rust/akka-http are all failing because they do not define what Travis considers to be valid test cases:

  • Crystal/moonshine only defines a redis test, this is being fixed in Add Redis as valid database #1653
  • The two Rust frameworks have the empty string as their database. I will make a fix right now to set this to "None".

Hopefully those two changes will clean up Travis for working tests such as this. Please test manually for confidence and merge.

@msmith-techempower
Copy link
Copy Markdown
Member

Man... Travis is letting me down of late - this worked locally; LGTM!

msmith-techempower added a commit that referenced this pull request Jun 10, 2015
@msmith-techempower msmith-techempower merged commit 9c10277 into TechEmpower:master Jun 10, 2015
@zane-techempower zane-techempower deleted the improve-hapi branch June 20, 2015 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants