Verification change for charset#1810
Conversation
@ssmith-techempower then this should not be a warning, correct? Edit: Ah, maybe I have misunderstood. I assumed we were taking off the warning for all text responses, including text/plain as it has the same implications on browser security as text/html. |
ddbc264 to
c948188
Compare
|
@nbrady-techempower @ssmith-techempower I think you need to remove this warning as it is now a requirement and should therefore be an error. |
…erification will now accept the correct content type regardless of whether or not charset is included
|
After some internal discussion, we've decided that |
|
Hard to know who this would affect, but since most of the tests we expect to pass are, I say LGTM! |
Verification change for charset
Previously, we would flag responses that set a
charsetas warnings as this extra header data was unnecessary and may impact performance. After some internal discussions, it's been decided that thecharsetshould be considered mandatory fortext/html, which is the content type for the fortunes test. This PR changes the verification script to reflect this. Failure to includecharsetfortext/htmlor includingcharsetfor other content types is flagged as a warning.