/FrameworkBenchmarks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compojure and http-kit: Update dependencies and sync implemetations #1855

Merged
merged 1 commit into from Jan 8, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@k-r-g @nbrady-techempower
@k-r-g
Contributor

k-r-g commented Jan 6, 2016

Dependencies:

  • Use Java8 instead of Java7
  • In project.clj, use current versions of dependencies

Implementation synchronization: In handler.clj, make the Compojure and
http-kit implementations as close to identical as possible. Specifically:
Keith R. Gustafson
Compojure and http-kit: Update dependencies and synchronize implement… 
…ations

Dependencies:
 - Use Java8 instead of Java7
 - In project.clj, use current versions of dependencies

Implementation synchronization: In handler.clj, make the Compojure and
http-kit implementations as close to identical as possible. Specifically:
 - Fix up Compojure implementation to better follow the Clojure Style
   Guide (https://github.com/bbatsov/clojure-style-guide) as http-kit does.
 - Normalize route paths.
 - Add a "raw" jdbc implementation for http-kit.
db17045
@nbrady-techempower

This comment has been minimized.

Show comment
Hide comment
@nbrady-techempower

nbrady-techempower Jan 8, 2016

Member

All tests pass locally as well. Merging!

================================================================================
  Verification Summary

| Test: compojure
|       fortune     : WARN
|       plaintext   : WARN
|       db          : WARN
|       update      : WARN
|       json        : WARN
|       query       : WARN
================================================================================
================================================================================
  Verification Summary

| Test: http-kit
|       fortune     : WARN
|       plaintext   : PASS
|       db          : WARN
|       update      : WARN
|       json        : WARN
|       query       : WARN
================================================================================
Member

nbrady-techempower commented Jan 8, 2016

All tests pass locally as well. Merging!

================================================================================
  Verification Summary

| Test: compojure
|       fortune     : WARN
|       plaintext   : WARN
|       db          : WARN
|       update      : WARN
|       json        : WARN
|       query       : WARN
================================================================================
================================================================================
  Verification Summary

| Test: http-kit
|       fortune     : WARN
|       plaintext   : PASS
|       db          : WARN
|       update      : WARN
|       json        : WARN
|       query       : WARN
================================================================================

@nbrady-techempower nbrady-techempower closed this Jan 8, 2016

@nbrady-techempower nbrady-techempower reopened this Jan 8, 2016

nbrady-techempower added a commit that referenced this pull request Jan 8, 2016

@nbrady-techempower
Merge pull request #1855 from k-r-g/clojure-updates 
Compojure and http-kit: Update dependencies and sync implemetations
741cd6d

@nbrady-techempower nbrady-techempower merged commit 741cd6d into TechEmpower:master Jan 8, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@k-r-g k-r-g deleted the k-r-g:clojure-updates branch Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment