This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Compojure and http-kit: Update dependencies and sync implemetations#1855
Merged
NateBrady23 merged 1 commit intoTechEmpower:masterfrom Jan 8, 2016
Merged
Compojure and http-kit: Update dependencies and sync implemetations#1855NateBrady23 merged 1 commit intoTechEmpower:masterfrom
NateBrady23 merged 1 commit intoTechEmpower:masterfrom
Conversation
…ations Dependencies: - Use Java8 instead of Java7 - In project.clj, use current versions of dependencies Implementation synchronization: In handler.clj, make the Compojure and http-kit implementations as close to identical as possible. Specifically: - Fix up Compojure implementation to better follow the Clojure Style Guide (https://github.com/bbatsov/clojure-style-guide) as http-kit does. - Normalize route paths. - Add a "raw" jdbc implementation for http-kit.
Member
|
All tests pass locally as well. Merging! |
NateBrady23
added a commit
that referenced
this pull request
Jan 8, 2016
Compojure and http-kit: Update dependencies and sync implemetations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependencies:
Implementation synchronization: In handler.clj, make the Compojure and
http-kit implementations as close to identical as possible. Specifically:
Guide (https://github.com/bbatsov/clojure-style-guide) as http-kit does.