/FrameworkBenchmarks

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kemal issues due to pool version #2022

Merged
merged 1 commit into from Apr 22, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@cjnething @msmith-techempower
@cjnething
Contributor

cjnething commented Apr 6, 2016

  • Lock pool version to 0.2.1 (latest version 0.2.2 is for Crystal 0.14 or later, which has breaking changes)
  • Delete redis tests per PR #1955
  • Put quotes around strings to make style more consistent

Please note: my local version did not pass due to an error that Crystal is aware of but Travis did pass.
@cjnething
Lock pool to specific commit and get rid of redis tests 
Lock pool version to 0.2.1

Put quotes around strings to make style more consistent
Lock pool to specific version and delete redis tests
ba3f704

@cjnething cjnething added the Bug: Framework label Apr 6, 2016

@cjnething cjnething added this to the Round 13 milestone Apr 6, 2016

@cjnething cjnething changed the title from Lock pool to specific commit and get rid of redis tests to Fix Kemal issues due to pool version Apr 6, 2016

@msmith-techempower msmith-techempower merged commit d32860e into TechEmpower:master Apr 22, 2016
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment