Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Update Rust#2031

Closed
steveklabnik wants to merge 4 commits intoTechEmpower:masterfrom
steveklabnik:rust-1.8
Closed

Update Rust#2031
steveklabnik wants to merge 4 commits intoTechEmpower:masterfrom
steveklabnik:rust-1.8

Conversation

@steveklabnik
Copy link
Copy Markdown
Contributor

Two things:

  1. let's DRY this slightly so that we can change one version and update everything. Easier and more accurate.
  2. Update to Rust 1.8.

@steveklabnik
Copy link
Copy Markdown
Contributor Author

The rust tests are all passing, it's only other things that are failling.

@msmith-techempower msmith-techempower added this to the Post Round-13 milestone Apr 29, 2016
@jadbox
Copy link
Copy Markdown

jadbox commented May 26, 2016

@steveklabnik Can you update this to Rust 1.9 (was released this week with several perf improvements, notably strings).

@steveklabnik
Copy link
Copy Markdown
Contributor Author

I can and will! It'll be tomorrow though.

@steveklabnik
Copy link
Copy Markdown
Contributor Author

I pushed a new commit that updates to 1.9, and upgrades some other versions. Let's see what CI says!

@steveklabnik
Copy link
Copy Markdown
Contributor Author

All rust stuff passed, this should be good to go!

@NateBrady23
Copy link
Copy Markdown
Member

Hi @steveklabnik we are getting ready to start our preview runs for round-13. In the meantime we are preparing to start work on verifying pull requests for round-14. Because of this, we are slightly restructuring our branches. Would you mind closing this and making a pull request that targets the new round-14 branch? Thanks!

Here's more information: http://frameworkbenchmarks.readthedocs.io/en/latest/Development/Contributing-Guide/#github-pull-request-procedure

@steveklabnik
Copy link
Copy Markdown
Contributor Author

Absolutely!

So you know what the schedule is? It'd be nice if we could maybe work on doing some work before the next benchmark is taken.

On Jun 15, 2016, 00:17 +0100, Natenotifications@github.com, wrote:

Hi@steveklabnik(https://github.com/steveklabnik)we are getting ready to start our preview runs for round-13. In the meantime we are preparing to start work on verifying pull requests for round-14. Because of this, we are slightly restructuring our branches. Would you mind closing this and making a pull request that targets the new round-14 branch? Thanks!

Here's more information:http://frameworkbenchmarks.readthedocs.io/en/latest/Development/Contributing-Guide/#github-pull-request-procedure


You are receiving this because you were mentioned.
Reply to this email directly,view it on GitHub(#2031 (comment)), ormute the thread(https://github.com/notifications/unsubscribe/AABsihTcju37Eqh4yS6fNiuc-jEYPnQKks5qLzZzgaJpZM4IQcBB).

@NateBrady23
Copy link
Copy Markdown
Member

@steveklabnik we won't be getting any work in for round-13 but with this new model we'll be able to do simultaneous testing and merging of current and future rounds so when, like now, a round is "frozen" we won't have PRs sitting waiting for feedback. We can get them tested and merged in to the round they're targeting. This also gets us closer to a continuous benchmarking goal. We want the contributors to see faster turnaround on all the hard work they do!

@steveklabnik
Copy link
Copy Markdown
Contributor Author

Cool. 👍 sending new PR now

@steveklabnik steveklabnik mentioned this pull request Jun 15, 2016
@LadyMozzarella LadyMozzarella modified the milestones: Round 13, Post Round-13 Aug 26, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants